mirror of
https://github.com/lkl/linux.git
synced 2025-12-19 16:13:19 +09:00
6b5c13b591
The clients array references all registered clients and is protected by
the clients_lock. Besides its use as general list of clients the clients
array is accessed in ism_handle_irq() to forward ISM device events to
clients.
While the clients_lock is taken in the IRQ handler when calling
handle_event() it is however incorrectly not held during the
client->handle_irq() call and for the preceding clients[] access leaving
it unprotected against concurrent client (un-)registration.
Furthermore the accesses to ism->sba_client_arr[] in ism_register_dmb()
and ism_unregister_dmb() are not protected by any lock. This is
especially problematic as the client ID from the ism->sba_client_arr[]
is not checked against NO_CLIENT and neither is the client pointer
checked.
Instead of expanding the use of the clients_lock further add a separate
array in struct ism_dev which references clients subscribed to the
device's events and IRQs. This array is protected by ism->lock which is
already taken in ism_handle_irq() and can be taken outside the IRQ
handler when adding/removing subscribers or the accessing
ism->sba_client_arr[]. This also means that the clients_lock is no
longer taken in IRQ context.
Fixes: 89e7d2ba61 ("net/ism: Add new API for client registration")
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
100 lines
2.3 KiB
C
100 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Internal Shared Memory
|
|
*
|
|
* Definitions for the ISM module
|
|
*
|
|
* Copyright IBM Corp. 2022
|
|
*/
|
|
#ifndef _ISM_H
|
|
#define _ISM_H
|
|
|
|
#include <linux/workqueue.h>
|
|
|
|
struct ism_dmb {
|
|
u64 dmb_tok;
|
|
u64 rgid;
|
|
u32 dmb_len;
|
|
u32 sba_idx;
|
|
u32 vlan_valid;
|
|
u32 vlan_id;
|
|
void *cpu_addr;
|
|
dma_addr_t dma_addr;
|
|
};
|
|
|
|
/* Unless we gain unexpected popularity, this limit should hold for a while */
|
|
#define MAX_CLIENTS 8
|
|
#define ISM_NR_DMBS 1920
|
|
|
|
struct ism_dev {
|
|
spinlock_t lock; /* protects the ism device */
|
|
struct list_head list;
|
|
struct pci_dev *pdev;
|
|
|
|
struct ism_sba *sba;
|
|
dma_addr_t sba_dma_addr;
|
|
DECLARE_BITMAP(sba_bitmap, ISM_NR_DMBS);
|
|
u8 *sba_client_arr; /* entries are indices into 'clients' array */
|
|
void *priv[MAX_CLIENTS];
|
|
|
|
struct ism_eq *ieq;
|
|
dma_addr_t ieq_dma_addr;
|
|
|
|
struct device dev;
|
|
u64 local_gid;
|
|
int ieq_idx;
|
|
|
|
struct ism_client *subs[MAX_CLIENTS];
|
|
atomic_t free_clients_cnt;
|
|
atomic_t add_dev_cnt;
|
|
wait_queue_head_t waitq;
|
|
};
|
|
|
|
struct ism_event {
|
|
u32 type;
|
|
u32 code;
|
|
u64 tok;
|
|
u64 time;
|
|
u64 info;
|
|
};
|
|
|
|
struct ism_client {
|
|
const char *name;
|
|
void (*add)(struct ism_dev *dev);
|
|
void (*remove)(struct ism_dev *dev);
|
|
void (*handle_event)(struct ism_dev *dev, struct ism_event *event);
|
|
/* Parameter dmbemask contains a bit vector with updated DMBEs, if sent
|
|
* via ism_move_data(). Callback function must handle all active bits
|
|
* indicated by dmbemask.
|
|
*/
|
|
void (*handle_irq)(struct ism_dev *dev, unsigned int bit, u16 dmbemask);
|
|
/* Private area - don't touch! */
|
|
struct work_struct remove_work;
|
|
struct work_struct add_work;
|
|
struct ism_dev *tgt_ism;
|
|
u8 id;
|
|
};
|
|
|
|
int ism_register_client(struct ism_client *client);
|
|
int ism_unregister_client(struct ism_client *client);
|
|
static inline void *ism_get_priv(struct ism_dev *dev,
|
|
struct ism_client *client) {
|
|
return dev->priv[client->id];
|
|
}
|
|
|
|
static inline void ism_set_priv(struct ism_dev *dev, struct ism_client *client,
|
|
void *priv) {
|
|
dev->priv[client->id] = priv;
|
|
}
|
|
|
|
int ism_register_dmb(struct ism_dev *dev, struct ism_dmb *dmb,
|
|
struct ism_client *client);
|
|
int ism_unregister_dmb(struct ism_dev *dev, struct ism_dmb *dmb);
|
|
int ism_move(struct ism_dev *dev, u64 dmb_tok, unsigned int idx, bool sf,
|
|
unsigned int offset, void *data, unsigned int size);
|
|
u8 *ism_get_seid(void);
|
|
|
|
const struct smcd_ops *ism_get_smcd_ops(void);
|
|
|
|
#endif /* _ISM_H */
|