Files
lkl_linux/include/linux
Eric Dumazet 2695578b89 net: usbnet: fix potential deadlock on 32bit hosts
Marek reported a LOCKDEP issue occurring on 32bit host,
that we tracked down to the fact that usbnet could either
run from soft or hard irqs.

This patch adds u64_stats_update_begin_irqsave() and
u64_stats_update_end_irqrestore() helpers to solve this case.

[   17.768040] ================================
[   17.772239] WARNING: inconsistent lock state
[   17.776511] 4.16.0-rc3-next-20180227-00007-g876c53a7493c #453 Not tainted
[   17.783329] --------------------------------
[   17.787580] inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage.
[   17.793607] swapper/0/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
[   17.798751]  (&syncp->seq#5){?.-.}, at: [<9b22e5f0>]
asix_rx_fixup_internal+0x188/0x288
[   17.806790] {IN-HARDIRQ-W} state was registered at:
[   17.811677]   tx_complete+0x100/0x208
[   17.815319]   __usb_hcd_giveback_urb+0x60/0xf0
[   17.819770]   xhci_giveback_urb_in_irq+0xa8/0x240
[   17.824469]   xhci_td_cleanup+0xf4/0x16c
[   17.828367]   xhci_irq+0xe74/0x2240
[   17.831827]   usb_hcd_irq+0x24/0x38
[   17.835343]   __handle_irq_event_percpu+0x98/0x510
[   17.840111]   handle_irq_event_percpu+0x1c/0x58
[   17.844623]   handle_irq_event+0x38/0x5c
[   17.848519]   handle_fasteoi_irq+0xa4/0x138
[   17.852681]   generic_handle_irq+0x18/0x28
[   17.856760]   __handle_domain_irq+0x6c/0xe4
[   17.860941]   gic_handle_irq+0x54/0xa0
[   17.864666]   __irq_svc+0x70/0xb0
[   17.867964]   arch_cpu_idle+0x20/0x3c
[   17.871578]   arch_cpu_idle+0x20/0x3c
[   17.875190]   do_idle+0x144/0x218
[   17.878468]   cpu_startup_entry+0x18/0x1c
[   17.882454]   start_kernel+0x394/0x400
[   17.886177] irq event stamp: 161912
[   17.889616] hardirqs last  enabled at (161912): [<7bedfacf>]
__netdev_alloc_skb+0xcc/0x140
[   17.897893] hardirqs last disabled at (161911): [<d58261d0>]
__netdev_alloc_skb+0x94/0x140
[   17.904903] exynos5-hsi2c 12ca0000.i2c: tx timeout
[   17.906116] softirqs last  enabled at (161904): [<387102ff>]
irq_enter+0x78/0x80
[   17.906123] softirqs last disabled at (161905): [<cf4c628e>]
irq_exit+0x134/0x158
[   17.925722].
[   17.925722] other info that might help us debug this:
[   17.933435]  Possible unsafe locking scenario:
[   17.933435].
[   17.940331]        CPU0
[   17.942488]        ----
[   17.944894]   lock(&syncp->seq#5);
[   17.948274]   <Interrupt>
[   17.950847]     lock(&syncp->seq#5);
[   17.954386].
[   17.954386]  *** DEADLOCK ***
[   17.954386].
[   17.962422] no locks held by swapper/0/0.

Fixes: c8b5d129ee ("net: usbnet: support 64bit stats")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-03-07 11:46:39 -05:00
..
2017-11-28 16:30:38 +01:00
2018-01-01 22:54:42 -08:00
2018-02-20 11:34:54 +00:00
2018-01-02 13:59:16 -05:00
2017-11-30 16:55:35 +00:00
2018-02-06 18:32:44 -08:00
2017-11-15 18:21:04 -08:00
2017-12-19 16:35:34 -08:00
2018-01-03 14:03:48 +01:00
2017-11-27 16:19:56 -05:00
2018-02-12 15:59:08 +00:00
2018-01-01 12:40:27 -07:00
2018-01-25 14:10:39 -08:00
2017-11-13 01:41:20 +01:00
2018-02-26 12:32:42 -08:00
2018-02-26 09:48:42 -07:00
2017-11-15 18:21:06 -08:00
2018-01-16 00:04:19 +01:00
2018-02-06 16:41:29 -05:00
2018-01-17 11:30:16 +00:00
2017-11-15 18:21:05 -08:00
2017-12-29 21:13:04 +01:00
2017-11-15 18:21:01 -08:00
2018-02-24 01:43:47 +01:00
2017-12-01 13:09:40 -08:00
2017-10-07 10:45:02 -06:00
2018-01-03 11:00:22 -05:00
2018-01-31 17:18:38 -08:00
2017-11-17 16:10:00 -08:00
2018-01-28 22:17:24 -05:00
2018-01-08 08:22:45 -06:00
2018-01-17 15:25:50 +01:00
2018-01-25 08:48:20 -06:00
2018-01-08 08:22:45 -06:00
2017-12-14 16:00:49 -08:00
2018-01-31 17:18:40 -08:00
2017-11-15 18:21:06 -08:00
2018-01-31 17:18:37 -08:00
2017-11-09 10:23:28 +01:00
2018-02-01 11:40:07 -06:00
2018-01-19 16:50:53 -08:00
2017-11-17 16:10:04 -08:00
2017-11-17 16:10:04 -08:00
2017-11-13 01:33:48 +01:00
2017-12-16 02:05:48 +01:00
2018-02-06 16:41:28 -05:00
2017-12-11 14:37:11 -07:00
2017-11-29 22:16:31 +01:00
2017-11-07 12:22:21 +01:00
2018-01-29 12:02:54 -05:00
2018-01-18 11:56:49 +01:00
2018-01-15 12:07:46 -08:00
2018-01-15 09:35:45 +01:00
2018-02-06 18:32:47 -08:00
2018-01-09 16:27:43 +01:00
2017-10-11 22:36:54 -04:00
2018-02-06 18:32:44 -08:00
2017-12-20 09:53:54 -07:00
2017-10-04 10:29:22 +02:00
2017-11-27 16:19:54 -05:00