aleph/lkl_linux
1
0
Fork 0
mirror of https://github.com/lkl/linux.git synced 2025-12-19 16:13:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

cpuidle: tracing: Warn about !rcu_is_watching()

Browse Source 
When using noinstr, WARN when tracing hits when RCU is disabled.

Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230126151323.466670589@infradead.org
This commit is contained in:
Peter Zijlstra
2023-01-26 16:08:32 +01:00
committed by Ingo Molnar
parent 5a5d7e9bad
commit d099dbfd33
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
include/linux/trace_recursion.h
View File

@@ -135,6 +135,21 @@ extern void ftrace_record_recursion(unsigned long ip, unsigned long parent_ip);
# define do_ftrace_record_recursion(ip, pip) do { } while (0) # define do_ftrace_record_recursion(ip, pip) do { } while (0)
#endif #endif
#ifdef CONFIG_ARCH_WANTS_NO_INSTR
# define trace_warn_on_no_rcu(ip) \
({ \
bool __ret = !rcu_is_watching(); \
if (__ret && !trace_recursion_test(TRACE_RECORD_RECURSION_BIT)) { \
trace_recursion_set(TRACE_RECORD_RECURSION_BIT); \
WARN_ONCE(true, "RCU not on for: %pS\n", (void *)ip); \
trace_recursion_clear(TRACE_RECORD_RECURSION_BIT); \
} \
__ret; \
})
#else
# define trace_warn_on_no_rcu(ip) false
#endif
/* /*
* Preemption is promised to be disabled when return bit >= 0. * Preemption is promised to be disabled when return bit >= 0.
*/ */
@@ -144,6 +159,9 @@ static __always_inline int trace_test_and_set_recursion(unsigned long ip, unsign
unsigned int val = READ_ONCE(current->trace_recursion); unsigned int val = READ_ONCE(current->trace_recursion);
int bit; int bit;
if (trace_warn_on_no_rcu(ip))
return -1;
bit = trace_get_context_bit() + start; bit = trace_get_context_bit() + start;
if (unlikely(val & (1 << bit))) { if (unlikely(val & (1 << bit))) {
/* /*