aleph/lkl_linux
1
0
Fork 0
mirror of https://github.com/lkl/linux.git synced 2025-12-19 16:13:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

NFS: Remove the nfs4_label from the nfs4_lookupp_res struct

Browse Source 
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
This commit is contained in:
Anna Schumaker
2021-10-22 13:11:05 -04:00
committed by Trond Myklebust
parent 9558a007db
commit ba4bc8dc4d
5 changed files with 16 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
fs/nfs/export.c
View File

@@ -131,7 +131,6 @@ nfs_get_parent(struct dentry *dentry)
struct super_block *sb = inode->i_sb; struct super_block *sb = inode->i_sb;
struct nfs_server *server = NFS_SB(sb); struct nfs_server *server = NFS_SB(sb);
struct nfs_fattr *fattr = NULL; struct nfs_fattr *fattr = NULL;
struct nfs4_label *label = NULL;
struct dentry *parent; struct dentry *parent;
struct nfs_rpc_ops const *ops = server->nfs_client->rpc_ops; struct nfs_rpc_ops const *ops = server->nfs_client->rpc_ops;
struct nfs_fh fh; struct nfs_fh fh;
@@ -139,31 +138,20 @@ nfs_get_parent(struct dentry *dentry)
if (!ops->lookupp) if (!ops->lookupp)
return ERR_PTR(-EACCES); return ERR_PTR(-EACCES);
fattr = nfs_alloc_fattr(); fattr = nfs_alloc_fattr_with_label(server);
if (fattr == NULL) { if (fattr == NULL)
parent = ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
ret = ops->lookupp(inode, &fh, fattr);
if (ret) {
parent = ERR_PTR(ret);
goto out; goto out;
} }
label = nfs4_label_alloc(server, GFP_KERNEL); pinode = nfs_fhget(sb, &fh, fattr, fattr->label);
if (IS_ERR(label)) {
parent = ERR_CAST(label);
goto out_free_fattr;
}
ret = ops->lookupp(inode, &fh, fattr, label);
if (ret) {
parent = ERR_PTR(ret);
goto out_free_label;
}
pinode = nfs_fhget(sb, &fh, fattr, label);
parent = d_obtain_alias(pinode); parent = d_obtain_alias(pinode);
out_free_label:
nfs4_label_free(label);
out_free_fattr:
nfs_free_fattr(fattr);
out: out:
nfs_free_fattr(fattr);
return parent; return parent;
} }

2
fs/nfs/nfs3proc.c
View File

@@ -208,7 +208,7 @@ nfs3_proc_lookup(struct inode *dir, struct dentry *dentry,
} }
static int nfs3_proc_lookupp(struct inode *inode, struct nfs_fh *fhandle, static int nfs3_proc_lookupp(struct inode *inode, struct nfs_fh *fhandle,
struct nfs_fattr *fattr, struct nfs4_label *label) struct nfs_fattr *fattr)
{ {
const char dotdot[] = ".."; const char dotdot[] = "..";
const size_t len = strlen(dotdot); const size_t len = strlen(dotdot);

10
fs/nfs/nfs4proc.c
View File

@@ -4416,8 +4416,7 @@ nfs4_proc_lookup_mountpoint(struct inode *dir, struct dentry *dentry,
} }
static int _nfs4_proc_lookupp(struct inode *inode, static int _nfs4_proc_lookupp(struct inode *inode,
struct nfs_fh *fhandle, struct nfs_fattr *fattr, struct nfs_fh *fhandle, struct nfs_fattr *fattr)
struct nfs4_label *label)
{ {
struct rpc_clnt *clnt = NFS_CLIENT(inode); struct rpc_clnt *clnt = NFS_CLIENT(inode);
struct nfs_server *server = NFS_SERVER(inode); struct nfs_server *server = NFS_SERVER(inode);
@@ -4429,7 +4428,6 @@ static int _nfs4_proc_lookupp(struct inode *inode,
struct nfs4_lookupp_res res = { struct nfs4_lookupp_res res = {
.server = server, .server = server,
.fattr = fattr, .fattr = fattr,
.label = label,
.fh = fhandle, .fh = fhandle,
}; };
struct rpc_message msg = { struct rpc_message msg = {
@@ -4442,7 +4440,7 @@ static int _nfs4_proc_lookupp(struct inode *inode,
if (NFS_SERVER(inode)->flags & NFS_MOUNT_SOFTREVAL) if (NFS_SERVER(inode)->flags & NFS_MOUNT_SOFTREVAL)
task_flags |= RPC_TASK_TIMEOUT; task_flags |= RPC_TASK_TIMEOUT;
args.bitmask = nfs4_bitmask(server, label); args.bitmask = nfs4_bitmask(server, fattr->label);
nfs_fattr_init(fattr); nfs_fattr_init(fattr);
@@ -4454,14 +4452,14 @@ static int _nfs4_proc_lookupp(struct inode *inode,
} }
static int nfs4_proc_lookupp(struct inode *inode, struct nfs_fh *fhandle, static int nfs4_proc_lookupp(struct inode *inode, struct nfs_fh *fhandle,
struct nfs_fattr *fattr, struct nfs4_label *label) struct nfs_fattr *fattr)
{ {
struct nfs4_exception exception = { struct nfs4_exception exception = {
.interruptible = true, .interruptible = true,
}; };
int err; int err;
do { do {
err = _nfs4_proc_lookupp(inode, fhandle, fattr, label); err = _nfs4_proc_lookupp(inode, fhandle, fattr);
trace_nfs4_lookupp(inode, err); trace_nfs4_lookupp(inode, err);
err = nfs4_handle_exception(NFS_SERVER(inode), err, err = nfs4_handle_exception(NFS_SERVER(inode), err,
&exception); &exception);

2
fs/nfs/nfs4xdr.c
View File

@@ -6201,7 +6201,7 @@ static int nfs4_xdr_dec_lookupp(struct rpc_rqst *rqstp, struct xdr_stream *xdr,
status = decode_getfh(xdr, res->fh); status = decode_getfh(xdr, res->fh);
if (status) if (status)
goto out; goto out;
status = decode_getfattr_label(xdr, res->fattr, res->label, res->server); status = decode_getfattr_label(xdr, res->fattr, res->fattr->label, res->server);
out: out:
return status; return status;
} }

3
include/linux/nfs_xdr.h
View File

@@ -1108,7 +1108,6 @@ struct nfs4_lookupp_res {
const struct nfs_server *server; const struct nfs_server *server;
struct nfs_fattr *fattr; struct nfs_fattr *fattr;
struct nfs_fh *fh; struct nfs_fh *fh;
struct nfs4_label *label;
}; };
struct nfs4_lookup_root_arg { struct nfs4_lookup_root_arg {
@@ -1741,7 +1740,7 @@ struct nfs_rpc_ops {
int (*lookup) (struct inode *, struct dentry *, int (*lookup) (struct inode *, struct dentry *,
struct nfs_fh *, struct nfs_fattr *); struct nfs_fh *, struct nfs_fattr *);
int (*lookupp) (struct inode *, struct nfs_fh *, int (*lookupp) (struct inode *, struct nfs_fh *,
struct nfs_fattr *, struct nfs4_label *); struct nfs_fattr *);
int (*access) (struct inode *, struct nfs_access_entry *); int (*access) (struct inode *, struct nfs_access_entry *);
int (*readlink)(struct inode *, struct page *, unsigned int, int (*readlink)(struct inode *, struct page *, unsigned int,
unsigned int); unsigned int);