aleph/lkl_linux
1
0
Fork 0
mirror of https://github.com/lkl/linux.git synced 2025-12-19 16:13:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

driver core: remove DRIVER_ATTR

Browse Source 
DRIVER_ATTR is no longer in use, and driver authors should be using
DRIVER_ATTR_RW() or DRIVER_ATTR_RO() or DRIVER_ATTR_WO() instead in
order to always get the permissions correct.  So remove it so that no
one can use it anymore.

Acked-by: Alan Tull <atull@kernel.org>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman
2017-09-18 12:17:57 +02:00
parent 55e001aabb
commit 850fdec8d2
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Documentation/driver-model/driver.txt
View File

@@ -196,12 +196,13 @@ struct driver_attribute {
}; };
Device drivers can export attributes via their sysfs directories. Device drivers can export attributes via their sysfs directories.
Drivers can declare attributes using a DRIVER_ATTR macro that works Drivers can declare attributes using a DRIVER_ATTR_RW and DRIVER_ATTR_RO
identically to the DEVICE_ATTR macro. macro that works identically to the DEVICE_ATTR_RW and DEVICE_ATTR_RO
macros.
Example: Example:
DRIVER_ATTR(debug,0644,show_debug,store_debug); DRIVER_ATTR_RW(debug);
This is equivalent to declaring: This is equivalent to declaring:

3
Documentation/filesystems/sysfs.txt
View File

@@ -366,7 +366,8 @@ struct driver_attribute {
Declaring: Declaring:
DRIVER_ATTR(_name, _mode, _show, _store) DRIVER_ATTR_RO(_name)
DRIVER_ATTR_RW(_name)
Creation/Removal: Creation/Removal:

2
include/linux/device.h
View File

@@ -307,8 +307,6 @@ struct driver_attribute {
size_t count); size_t count);
}; };
#define DRIVER_ATTR(_name, _mode, _show, _store) \
struct driver_attribute driver_attr_##_name = __ATTR(_name, _mode, _show, _store)
#define DRIVER_ATTR_RW(_name) \ #define DRIVER_ATTR_RW(_name) \
struct driver_attribute driver_attr_##_name = __ATTR_RW(_name) struct driver_attribute driver_attr_##_name = __ATTR_RW(_name)
#define DRIVER_ATTR_RO(_name) \ #define DRIVER_ATTR_RO(_name) \