aleph/lkl_linux
1
0
Fork 0
mirror of https://github.com/lkl/linux.git synced 2025-12-19 16:13:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

vfs: fix up the assert in i_readcount_dec

Browse Source 
Drops a race where 2 threads could spot a positive value and both
proceed to dec to -1, without reporting anything.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Message-Id: <20230811194814.1612336-1-mjguzik@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Mateusz Guzik
2023-08-11 21:48:14 +02:00
committed by Christian Brauner
parent 89cbd4c036
commit 45e0d4b95b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/linux/fs.h
View File

@@ -2607,8 +2607,7 @@ static inline bool inode_is_open_for_write(const struct inode *inode)
#if defined(CONFIG_IMA) || defined(CONFIG_FILE_LOCKING) #if defined(CONFIG_IMA) || defined(CONFIG_FILE_LOCKING)
static inline void i_readcount_dec(struct inode *inode) static inline void i_readcount_dec(struct inode *inode)
{ {
BUG_ON(!atomic_read(&inode->i_readcount)); BUG_ON(atomic_dec_return(&inode->i_readcount) < 0);
atomic_dec(&inode->i_readcount);
} }
static inline void i_readcount_inc(struct inode *inode) static inline void i_readcount_inc(struct inode *inode)
{ {