aleph/lkl_linux
1
0
Fork 0
mirror of https://github.com/lkl/linux.git synced 2025-12-19 16:13:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

SUNRPC: Change return value type of .pc_encode

Browse Source 
Returning an undecorated integer is an age-old trope, but it's
not clear (even to previous experts in this code) that the only
valid return values are 1 and 0. These functions do not return
a negative errno, rpc_stat value, or a positive length.

Document there are only two valid return values by having
.pc_encode return only true or false.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Chuck Lever
2021-10-13 10:41:13 -04:00
committed by J. Bruce Fields
parent fda4944114
commit 130e2054d4
16 changed files with 183 additions and 183 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/linux/lockd/xdr.h
View File

@@ -106,9 +106,9 @@ bool nlmsvc_decode_reboot(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlmsvc_decode_shareargs(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlmsvc_decode_notify(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlmsvc_encode_testres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlmsvc_encode_res(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlmsvc_encode_void(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlmsvc_encode_shareres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlmsvc_encode_testres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlmsvc_encode_res(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlmsvc_encode_void(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlmsvc_encode_shareres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
#endif /* LOCKD_XDR_H */

8
include/linux/lockd/xdr4.h
View File

@@ -32,10 +32,10 @@ bool nlm4svc_decode_reboot(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlm4svc_decode_shareargs(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlm4svc_decode_notify(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlm4svc_encode_testres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlm4svc_encode_res(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlm4svc_encode_void(struct svc_rqst *rqstp, struct xdr_stream *xdr);
int nlm4svc_encode_shareres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlm4svc_encode_testres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlm4svc_encode_res(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlm4svc_encode_void(struct svc_rqst *rqstp, struct xdr_stream *xdr);
bool nlm4svc_encode_shareres(struct svc_rqst *rqstp, struct xdr_stream *xdr);
extern const struct rpc_version nlm_version4;