aleph/lkl_linux
1
0
Fork 0
mirror of https://github.com/lkl/linux.git synced 2025-12-19 16:13:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

firewire: core: obsolete usage of GFP_ATOMIC at building node tree

Browse Source 
The flag of GFP_ATOMIC is given to the call of kmalloc when building node
tree, but the call is not atomic context. The call of
fw_core_handle_bus_reset() and fw_core_remove_card() builds the tree,
while they are done in specific workqueue or pci remove callback.

This commit obsolete the usage of GFP_ATOMIC.

Link: https://lore.kernel.org/r/20230604070255.172700-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto
2023-06-04 16:02:55 +09:00
parent 5716e58aec
commit 06f45435d9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/firewire/core-device.c
View File

@@ -1211,7 +1211,7 @@ void fw_node_event(struct fw_card *card, struct fw_node *node, int event)
* without actually having a link. * without actually having a link.
*/ */
create: create:
device = kzalloc(sizeof(*device), GFP_ATOMIC); device = kzalloc(sizeof(*device), GFP_KERNEL);
if (device == NULL) if (device == NULL)
break; break;

2
drivers/firewire/core-topology.c
View File

@@ -101,7 +101,7 @@ static struct fw_node *fw_node_create(u32 sid, int port_count, int color)
{ {
struct fw_node *node; struct fw_node *node;
node = kzalloc(struct_size(node, ports, port_count), GFP_ATOMIC); node = kzalloc(struct_size(node, ports, port_count), GFP_KERNEL);
if (node == NULL) if (node == NULL)
return NULL; return NULL;